Use periodic batching sink #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 2.0
2.1.0 Release
Release 2.1.1
Release 2.1.2
Release 2.1.3
Release 2.2.0
Release v2.3.0
The EventCollectorSink now inherits from PeriodicBatchingSink and allows the base class to handle the batching of log events. I've also removed the RepeatAction class as it was only used by the EventCollectorSink and is no longer necessary.
|
@CoderNumber1 thanks, will try to have a look today. |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@merbla This should fix #63 by making the
EventCollectorSinkinherit fromPeriodicBatchingSinkto handle batching log requests.